Fix Memory leak in ahocorasick #2258 #2518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 5, 2024 20:43
|
IvanNardi
requested changes
Aug 7, 2024
There was a problem hiding this comment.
@pavlinux, thank you very much for working on this issue!
Could you please
- rebase (to fix an unrelated error on CI)
- take a look at this error reported by the fuzzing tests (https://github.com/ntop/nDPI/actions/runs/10256768709)
==75==ERROR: AddressSanitizer: SEGV on unknown address 0x1001052ae2fb (pc 0x555921c54cc2 bp 0x7ffc295b19f0 sp 0x7ffc295b17c0 T0)
==75==The signal is caused by a READ memory access.
SCARINESS: 20 (wild-addr-read)
#0 0x555921c54cc2 in ac_automata_add /src/ndpi/src/lib/third_party/src/ahocorasick.c:259:21
#1 0x555921c50e88 in LLVMFuzzerTestOneInput /src/ndpi/fuzz/fuzz_ds_ahocorasick.cpp:88:11
- take a look at this error on Windows (https://github.com/ntop/nDPI/actions/runs/10256768615/job/28387471198?pr=2518)
D:\a\nDPI\nDPI\src\lib\third_party\src\ahocorasick.c(229,31): error C2057: expected constant expression [D:\a\nDPI\nDPI\windows\nDPI.vcxproj]
D:\a\nDPI\nDPI\src\lib\third_party\src\ahocorasick.c(229,31): error C2466: cannot allocate an array of constant size 0 [D:\a\nDPI\nDPI\windows\nDPI.vcxproj]
D:\a\nDPI\nDPI\src\lib\third_party\src\ahocorasick.c(229,32): error C2133: 'rev': unknown size [D:\a\nDPI\nDPI\windows\nDPI.vcxproj]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please sign (check) the below before submitting the Pull Request:
Link to the related issue:
Describe changes:
Fix Memory leak in ahocorasick #2258